Address a couple miscellaneous issues #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on fixing up a couple of tiny issues:
mecab.arm
file permissions. Whenever I run the plugin on an M1 Mac, it changes the permissions for this file, which produces a git change. I committed this change so that developers don't need to see this change when running their code./support/mecab
is already at this-rwxr-xr-x
permission level, so it felt OK to commit thismypy
errors in all of the files. There were a couple of linting errors in the source files, mostly around typing. I've updated these to make the errors go away.mypy
that I wasn't able to fix in this PR. I've opened Repository restructure to fix mypy issues? #22 for discussion.I've tested these changes on both Anki 2.1.54 and Anki 2.1.49.
Also, I wasn't sure (this is my first open-source project) if I should continue to maintain my fork, or push branches on this one now that I'm a contributor. If it wasn't OK for me to push to this repo, I'll continue to use my fork for any future work!